Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-6809

bootstrap_system.sh does an unconditional git clone to ~/Impala

    Details

    • Epic Color:
      ghx-label-4

      Description

      bootstrap_system.sh checks if ~/Impala is an existing directory, and if it isn't then clones Impala to that path. Once this is done this script jumps to ~/Impala and starts a build.

      In case someone clones the Impala sources to a custom directory, sources the Impala configs there and then invokes bootstrap_development.sh or bootstrap_system.sh then in the background the build is actually performed in ~/Impala instead of the custom dir. Taking into account that Impala is not sourced from ~/Impala, but the build is done there, this can result some strange build failures.

      My proposal is to move the following code behind a command line parameter that is off by default:

      # If there is no Impala git repo, get one now
      if ! [[ -d ~/Impala ]]
      then
        time -p git clone https://git-wip-us.apache.org/repos/asf/impala.git ~/Impala
      fi
      cd ~/Impala
      

        Attachments

          Activity

            People

            • Assignee:
              fredyw Fredy Wijaya
              Reporter:
              gaborkaszab Gabor Kaszab
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: