[IMPALA-6809] bootstrap_system.sh does an unconditional git clone to ~/Impala

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Done
• Affects Version/s: Impala 2.11.0
• Fix Version/s: Impala 3.0, Impala 2.12.0
• Component/s: Infrastructure
• Epic Color: ghx-label-4
• Assignee: Fredy Wijaya
• Reporter: Gabor Kaszab
• Created: 05/Apr/18 08:44
• Updated: 13/Apr/18 23:00
• Resolved: 13/Apr/18 02:32

Description

bootstrap_system.sh checks if ~/Impala is an existing directory, and if it isn't then clones Impala to that path. Once this is done this script jumps to ~/Impala and starts a build.

In case someone clones the Impala sources to a custom directory, sources the Impala configs there and then invokes bootstrap_development.sh or bootstrap_system.sh then in the background the build is actually performed in ~/Impala instead of the custom dir. Taking into account that Impala is not sourced from ~/Impala, but the build is done there, this can result some strange build failures.

My proposal is to move the following code behind a command line parameter that is off by default:

# If there is no Impala git repo, get one now
if ! [[ -d ~/Impala ]]
then
  time -p git clone https://git-wip-us.apache.org/repos/asf/impala.git ~/Impala
fi
cd ~/Impala