[IMPALA-6628] Use unqualified table references in .test files run from test_queries.py

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 4.0.0
• Component/s: Infrastructure
• Epic Color: ghx-label-2
• Assignee: Qifan Chen
• Reporter: Alexander Behm
• Created: 08/Mar/18 04:47
• Updated: 21/Oct/20 13:19
• Resolved: 21/Oct/20 13:19

Description

To increase our test coverage over different file formats we should go through the .test files referenced from test_queries.py and switch to using unqualified table references where possible.

The state today is that in the exhaustive exploration strategy we run every .test file once for every file format. However, since many .test use fully-qualified table references we are not actually getting coverage over all formats, so we are spending the time to run the tests but not getting the coverage we'd like.

I skimmed a few files and identified that at least these could be improved:
analytic-fns.test
subquery.test
limit.test
top-n.test

Likely there are more .test files. Probably there are similar issues in different .py files as well, but to keep this JIRA focused I propose we focus on test_queries.py first.

What to do

• Go through the .test files and change fully-qualified table references to unqualified table references where possible. Our test framework issues a "use <database" before running each such test. Different databases have different file formats.
• Example: The fully-qualified table reference "functional.alltypes" should be changed to an unqualified table reference "alltypes"
• Make sure the tests pass in exhaustive