Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-6124

test_last_ddl_time_update fails on S3

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: Impala 2.11.0
    • Fix Version/s: Impala 2.11.0
    • Component/s: Infrastructure
    • Labels:
      None

      Description

      This looks like the test took longer than 20s and thus failed. I don't understand why the two timestamps should be within 20s. My suggestion would be to change the check to something like this:

      assert long(afterDdlTime) - long(beforeDdlTime) > 0
      

      Alexander Behm - You wrote the original code. Do you remember why we perform this check? If you agree with the change I suggested, I'll go ahead and prepare a patch.

      05:53:22.493 =================================== FAILURES ===================================
      05:53:22.493  TestLastDdlTimeUpdate.test_alter[exec_option: {'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] 
      05:53:22.493 [gw0] linux2 -- Python 2.6.6 /data/jenkins/workspace/impala-umbrella-build-and-test-s3/repos/Impala/bin/../infra/python/env/bin/python
      05:53:22.493 metadata/test_last_ddl_time_update.py:57: in test_alter
      05:53:22.493     unique_database, TBL_NAME, True)
      05:53:22.493 metadata/test_last_ddl_time_update.py:120: in run_test
      05:53:22.493     assert long(afterDdlTime) - long(beforeDdlTime) <= 20
      05:53:22.493 E   assert (1509024836L - 1509024790L) <= 20
      05:53:22.493 E    +  where 1509024836L = long('1509024836')
      05:53:22.493 E    +  and   1509024790L = long('1509024790')
      05:53:22.493 ---------------------------- Captured stderr setup -----------------------------
      05:53:22.493 -- connecting to: localhost:21000
      05:53:22.493 SET sync_ddl=False;
      05:53:22.493 -- executing against localhost:21000
      05:53:22.493 DROP DATABASE IF EXISTS `test_alter_46f96e42` CASCADE;
      05:53:22.493 
      05:53:22.493 SET sync_ddl=False;
      05:53:22.493 -- executing against localhost:21000
      05:53:22.493 CREATE DATABASE `test_alter_46f96e42`;
      05:53:22.493 
      05:53:22.493 MainThread: Created database "test_alter_46f96e42" for test ID "metadata/test_last_ddl_time_update.py::TestLastDdlTimeUpdate::()::test_alter[exec_option: {'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none]"
      05:53:22.493 ----------------------------- Captured stderr call -----------------------------
      05:53:22.493 -- executing against localhost:21000
      05:53:22.493 create external table test_alter_46f96e42.alter_test_tbl (i int) partitioned by (j int, s string);
      05:53:22.493 
      05:53:22.493 -- executing against localhost:21000
      05:53:22.493 alter table test_alter_46f96e42.alter_test_tbl add partition (j=1, s='2012');
      05:53:22.493 
      05:53:22.493 -- executing against localhost:21000
      05:53:22.493 alter table test_alter_46f96e42.alter_test_tbl add if not exists partition (j=1, s='2012');
      05:53:22.493 
      05:53:22.493 -- executing against localhost:21000
      05:53:22.493 alter table test_alter_46f96e42.alter_test_tbl drop partition (j=1, s='2012');
      05:53:22.493 
      

        Attachments

          Activity

            People

            • Assignee:
              lv Lars Volker
              Reporter:
              lv Lars Volker
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: