[IMPALA-6093] TestHashJoinTimer failed on local filesystem and ASAN builds

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Impala 2.11.0
• Fix Version/s: Impala 2.11.0
• Component/s: Infrastructure
• Labels: flaky
• Target Version: Impala 2.11.0
• Epic Color: ghx-label-3
• Assignee: Tim Armstrong
• Reporter: Tim Armstrong
• Created: 20/Oct/17 19:16
• Updated: 01/Nov/17 21:34
• Resolved: 01/Nov/17 21:34

Description

04:26:05  TestHashJoinTimer.test_hash_join_timer[test cases: ['select /*+straight_join*/ count(*) from (select distinct * from functional.alltypes where int_col >= sleep(5)) a cross join  functional.alltypes b where a.id > b.id and b.id=99', 'NESTED LOOP JOIN'] | exec_option: {'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] 
04:26:05 query_test/test_hash_join_timer.py:140: in test_hash_join_timer
04:26:05     assert (asyn_build), "Join is not prepared asynchronously"
04:26:05 E   UnboundLocalError: local variable 'asyn_build' referenced before assignment

Saw this at commit: 2187d36... IMPALA-6045: Make build scripts more friendly to Ubuntu 16.04

The test seems fundamentally flaky, since the behaviour will change if there are enough other threads were running simultaneously and taking up threads that the query couldn't start an async build thread. It's worth thinking about how we can make this less flaky without losing coverage.