Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-6016

Confusing logging in TableLoadingMgr.loadNextTable()

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.9.0, Impala 2.10.0
    • Fix Version/s: Impala 2.11.0
    • Component/s: None
    • Labels:
      None
    • Epic Color:
      ghx-label-4

      Description

       private void loadNextTable() throws InterruptedException {
          // Always get the next table from the head of the deque.
          final TTableName tblName = tableLoadingDeque_.takeFirst();
          LOG.info("Loading next table from queue: " +
              tblName.db_name + "." + tblName.table_name);
          LOG.info(String.format("Remaining items in queue: %s. Loads in progress: %s",
              tableLoadingDeque_.size(), loadingTables_.size()));
      

      The last log is in an incorrect place, especially the "Loads in progress: %s" because the loadingTables_ for this specific load is not updated until loadAsync() is called and hence it doesn't reflect the actual situation.

      Given this is a useful log, we should move it to a place where it actually polls correct values.

        Attachments

          Activity

            People

            • Assignee:
              bharathv bharath v
              Reporter:
              bharathv bharath v
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: