Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5988

Improve MemPool::TryAllocate() efficiency for small strings

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • Impala 2.11.0
    • Backend

    Description

      There are some places in the code where we allocate many small strings from MemPool::TryAllocate(). The code is not particularly well optimised for this case. Specifically:

      • We always realign to the default alignment even when alignment isn't required.
      • The fast path through the code could be streamlined.

      I noticed this while working on IMPALA-5307 where I'm adding extra calls to allocate strings per-row.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tarmstrong Tim Armstrong
            tarmstrong Tim Armstrong
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment