Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5895

Simplify and document memory management of RuntimeProfile Counters

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 2.10.0
    • Impala 2.11.0
    • Backend
    • None

    Description

      It's very unclear what requirements there are around object lifetimes for RuntimeProfile objects and the Counter objects that live in ObjectPools. See IMPALA-5878 for a case where it's very hard to reason about correctness of the memory management.

      We should document the requirements and also consider simplifying the ownership model. E.g. having each RuntimeProfile own all of its counters via unique_ptrs.

      Attachments

        Issue Links

          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. IMPALA-4802 Fix lifecycle of RuntimeProfile

          • Major - Major loss of function.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. IMPALA-4802 Fix lifecycle of RuntimeProfile

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. IMPALA-5878 Segmentation fault in libjvm.so!SafepointSynchronize::begin() [breakpad?]

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            People

              tarmstrong Tim Armstrong
              tarmstrong Tim Armstrong
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: