Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-5895

Simplify and document memory management of RuntimeProfile Counters

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 2.10.0
    • Impala 2.11.0
    • Backend
    • None

    Description

      It's very unclear what requirements there are around object lifetimes for RuntimeProfile objects and the Counter objects that live in ObjectPools. See IMPALA-5878 for a case where it's very hard to reason about correctness of the memory management.

      We should document the requirements and also consider simplifying the ownership model. E.g. having each RuntimeProfile own all of its counters via unique_ptrs.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tarmstrong Tim Armstrong
            tarmstrong Tim Armstrong
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment