[IMPALA-5742] Memory leak in parquet-reader

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: Impala 2.10.0
• Labels: newbie
• Epic Color: ghx-label-2
• Assignee: Henry Robinson
• Reporter: Jim Apple
• Created: 31/Jul/17 05:05
• Updated: 04/Aug/17 17:14
• Resolved: 04/Aug/17 17:14

Description

Line 209 of parquet-reader {{malloc}}s memory it never frees, breaking ASAN tests on https://jenkins.impala.io:

 TestHdfsParquetTableWriter.test_def_level_encoding[exec_option: {'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: parquet/none] 
[gw0] linux2 -- Python 2.7.6 /home/ubuntu/Impala/bin/../infra/python/env/bin/python
query_test/test_insert_parquet.py:228: in test_def_level_encoding
    os.path.join(tmp_dir, str(f))])
/usr/lib/python2.7/subprocess.py:540: in check_call
    raise CalledProcessError(retcode, cmd)
E   CalledProcessError: Command '['/home/ubuntu/Impala/be/build/debug/util/parquet-reader', '--file', '/tmp/tmpbnxrl3/8948dc471cad29c8-45c9c81800000003_942829264_data.0.parq']' returned non-zero exit status 1

ERROR: LeakSanitizer: detected memory leaks

Direct leak of 43833 byte(s) in 1 object(s) allocated from:
    #0 0x1065588 in __interceptor_malloc /data/jenkins/workspace/verify-impala-toolchain-package-build/label/ec2-package-ubuntu-14-04/toolchain/source/llvm/llvm-3.8.0.src-p1/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:52
    #1 0x109b42c in main /home/ubuntu/Impala/be/src/util/parquet-reader.cc:209:48
    #2 0x7f08e0557f44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)

SUMMARY: AddressSanitizer: 43833 byte(s) leaked in 1 allocation(s).
-- executing against localhost:21000
drop table test_def_level_encoding_54e4df6c.test_hdfs_parquet_table_writer;