[IMPALA-5622] Ensure test coverage for spilling disabled for all spilling operators

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 2.10.0
• Component/s: Infrastructure
• Target Version: Impala 2.10.0
• Epic Color: ghx-label-6
• Assignee: Tim Armstrong
• Reporter: Tim Armstrong
• Created: 06/Jul/17 19:28
• Updated: 09/Aug/17 01:05
• Resolved: 09/Aug/17 01:05

Description

We should ensure that we have test coverage for disabling spilling. There are two dimensions. I don't think we need coverage of the whole matrix, but we need coverage along both dimensions.

Query operators:

• Agg - covered by TestScratchLimit
• Hash join - covered by TestScratchLimit (and with in-review IMPALA-5570 patch)
• Sort - covered by TestScratchLimit and TestScratchDir
• Analytic - covered by TestScratchLimit

Means of disabling:

• scratch_limit = 0 - covered by TestScratchLimit
• disable_unsafe_spills = true + a table missing stats - NOT COVERED
• starting up with no scratch disks - covered by TestScratchDir

Issue Links

• is related to: IMPALA-5780 Add missing test coverage for disable_unsafe_spills