[IMPALA-5341] File size filter in planner tests also filters row-size

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.5.0, Impala 2.6.0, Impala 2.7.0, Impala 2.8.0
• Fix Version/s: Impala 2.11.0
• Component/s: Infrastructure
• Labels: newbie
• Epic Color: ghx-label-4
• Assignee: Jin Chul Kim
• Reporter: Alexander Behm
• Created: 19/May/17 04:36
• Updated: 16/Nov/17 10:27
• Resolved: 16/Nov/17 10:27

Description

In our planner tests we want to ignore minor differences in reported file sizes to avoid flaky tests, see IMPALA-2565. However, the introduced filter also matches "row-size=" which we do not want to filter.

Relevant code is in TestUtils.java:

  static class FileSizeFilter implements ResultFilter {
    private final static String BYTE_FILTER = "[KMGT]?B";
    private final static String NUMBER_FILTER = "\\d+(\\.\\d+)?";
    private final static String FILTER_KEY = "size="; <-- also matches "row-size="

    public boolean matches(String input) { return input.contains(FILTER_KEY); }

    public String transform(String input) {
      return input.replaceAll(FILTER_KEY + NUMBER_FILTER + BYTE_FILTER, FILTER_KEY);
    }
  }