Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
Impala 2.9.0
-
None
-
None
Description
- We recently found several issues with integer overflows:
IMPALA-4995,IMPALA-4997,IMPALA-5021. To reduce the likelihood of similar issues we should make sure that all variables which store either a number of rows, number of tuples, or a number of bytes are of type int64_t.
Here are some useful commands to find candidates:
git grep -E "^ +int(|32_t) .*row" git grep -E "^ +int(|32_t) .*tuple" git grep -E "^ +int(|32_t) .*num_" git grep -E "^ +int(|32_t) .*bytes" git grep -E "^ +int(|32_t) .*size"