Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4721

Test names which are prefix of other tests make it impossible to select them using impala-py.test -k

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Information Provided
    • Affects Version/s: Impala 2.8.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Infrastructure
    • Labels:
      None

      Description

      For example, impala-py.test -k test_create_table also selects test test_create_table_as_select, since py.test only does containment checks.

      Here's a list of affected tests I found with a small script:

      tests/shell/test_shell_commandline.py:             test_multiple_queries               prefixes  test_multiple_queries_with_escaped_backslash
      tests/shell/test_shell_interactive.py:             test_source_file                    prefixes  test_source_file_with_errors
      tests/comparison/tests/test_cluster.py:            test_list_databases                 prefixes  test_list_databases
      tests/query_test/test_lifecycle.py:                test_failure_in_prepare             prefixes  test_failure_in_prepare_multi_fragment
      tests/query_test/test_aggregation.py:              test_aggregation                    prefixes  test_aggregation
      tests/query_test/test_mem_usage_scaling.py:        test_low_mem_limit_q1               prefixes  test_low_mem_limit_q10
      tests/query_test/test_mem_usage_scaling.py:        test_low_mem_limit_q2               prefixes  test_low_mem_limit_q20
      tests/query_test/test_mem_usage_scaling.py:        test_low_mem_limit_q5               prefixes  test_low_mem_limit_q53
      tests/query_test/test_sort.py:                     test_multiple_mem_limits            prefixes  test_multiple_mem_limits_full_output
      tests/query_test/test_tpcds_queries.py:            test_tpcds_q3                       prefixes  test_tpcds_q34
      tests/query_test/test_tpcds_queries.py:            test_tpcds_q6                       prefixes  test_tpcds_q61
      tests/query_test/test_tpcds_queries.py:            test_tpcds_q7                       prefixes  test_tpcds_q73
      tests/query_test/test_tpcds_queries.py:            test_tpcds_q8                       prefixes  test_tpcds_q88
      tests/query_test/test_queries.py:                  test_inline_view                    prefixes  test_inline_view_limit
      tests/query_test/test_scratch_limit.py:            test_with_zero_scratch_limit        prefixes  test_with_zero_scratch_limit_no_memory_limit
      tests/query_test/test_join_queries.py:             test_outer_joins                    prefixes  test_outer_joins
      tests/query_test/test_join_queries.py:             test_semi_joins                     prefixes  test_semi_joins_exhaustive
      tests/query_test/test_join_queries.py:             test_single_node_nested_loop_joins  prefixes  test_single_node_nested_loop_joins_exhaustive
      tests/query_test/test_delimited_text.py:           test_delimited_text                 prefixes  test_delimited_text_latin_chars
      tests/query_test/test_insert_parquet.py:           test_insert_parquet                 prefixes  test_insert_parquet_invalid_codec
      tests/query_test/test_runtime_filters.py:          test_row_filters                    prefixes  test_row_filters_phj_only
      tests/query_test/test_scanners.py:                 test_multiple_blocks                prefixes  test_multiple_blocks_one_row_group
      tests/query_test/test_scanners.py:                 test_scan_truncated_file            prefixes  test_scan_truncated_file_empty
      tests/query_test/test_scanners.py:                 test_text_scanner                   prefixes  test_text_scanner_with_header
      tests/query_test/test_mt_dop.py:                   test_parquet                        prefixes  test_parquet_nested
      tests/query_test/test_tpch_nested_queries.py:      test_tpch_q1                        prefixes  test_tpch_q10
      tests/query_test/test_tpch_nested_queries.py:      test_tpch_q2                        prefixes  test_tpch_q20
      tests/query_test/test_kudu.py:                     test_explicit_name                  prefixes  test_explicit_name_doesnt_exist
      tests/query_test/test_kudu.py:                     test_explicit_name_doesnt_exist     prefixes  test_explicit_name_doesnt_exist_but_implicit_does
      tests/query_test/test_query_opts.py:               test_set_invalid_query_option       prefixes  test_set_invalid_query_option
      tests/metadata/test_metadata_query_statements.py:  test_show                           prefixes  test_show_data_sources
      tests/metadata/test_compute_stats.py:              test_compute_stats                  prefixes  test_compute_stats_impala_2201
      tests/metadata/test_compute_stats.py:              test_hbase_compute_stats            prefixes  test_hbase_compute_stats_incremental
      tests/metadata/test_ddl.py:                        test_create_table                   prefixes  test_create_table_as_select
      tests/custom_cluster/test_query_expiration.py:     test_query_expiration               prefixes  test_query_expiration_no_default
      tests/custom_cluster/test_insert_behaviour.py:     test_insert_inherit_permission      prefixes  test_insert_inherit_permission_disabled
      tests/hs2/test_hs2.py:                             test_change_default_database        prefixes  test_change_default_database_case_insensitive
      tests/hs2/test_hs2.py:                             test_get_operation_status           prefixes  test_get_operation_status_error
      tests/hs2/test_hs2.py:                             test_open_session                   prefixes  test_open_session_empty_user
      

        Activity

        Hide
        lv Lars Volker added a comment -

        After IMPALA-4735 has been merged, tests can be selected like so:

        impala-py.test tests/query_test/test_scanners.py::TestTextScanRangeLengths::test_text_scanner_with_header

        Show
        lv Lars Volker added a comment - After IMPALA-4735 has been merged, tests can be selected like so: impala-py.test tests/query_test/test_scanners.py::TestTextScanRangeLengths::test_text_scanner_with_header

          People

          • Assignee:
            lv Lars Volker
            Reporter:
            lv Lars Volker
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development