Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4676

Remove vestigial references to getBlockStorageLocations() API

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Impala 2.8.0
    • Fix Version/s: Impala 2.9.0
    • Component/s: Frontend
    • Labels:
      None

      Description

      When experimenting with building against Hadoop 3 I found that the IMPALA-4172/IMPALA-3653 fix left a couple of references to the old API:

      • import org.apache.hadoop.fs.BlockStorageLocation;
      • DFSConfigKeys.DFS_CLIENT_FILE_BLOCK_STORAGE_LOCATIONS_TIMEOUT_MS
      • DFSConfigKeys.DFS_CLIENT_FILE_BLOCK_STORAGE_LOCATIONS_TIMEOUT_MS_DEFAULT

      We should remove this dead code.

        Activity

        Hide
        tarmstrong Tim Armstrong added a comment -

        IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

        The BlockStorageLocation import is unused.

        Remove validation of config keys that only affect the
        BlockStorageLocation API. See HDFS-10868 and HDFS-8895. We do not
        need to validate these keys any more since we don't use that API.
        These config keys are removed in Hadoop 3 so this patch is
        required to build against it.

        Change-Id: Ic12337a9f5b7d910282aaf7d8508a4176cf89cbc
        Reviewed-on: http://gerrit.cloudera.org:8080/5526
        Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        tarmstrong Tim Armstrong added a comment - IMPALA-4676 : remove vestigial references to getBlockStorageLocations() API The BlockStorageLocation import is unused. Remove validation of config keys that only affect the BlockStorageLocation API. See HDFS-10868 and HDFS-8895 . We do not need to validate these keys any more since we don't use that API. These config keys are removed in Hadoop 3 so this patch is required to build against it. Change-Id: Ic12337a9f5b7d910282aaf7d8508a4176cf89cbc Reviewed-on: http://gerrit.cloudera.org:8080/5526 Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com> Tested-by: Impala Public Jenkins
        Hide
        tarmstrong Tim Armstrong added a comment -

        I missed a reference - HdfsTable.java has a bunch of duplicated imports.

        Show
        tarmstrong Tim Armstrong added a comment - I missed a reference - HdfsTable.java has a bunch of duplicated imports.
        Hide
        tarmstrong Tim Armstrong added a comment -

        IMPALA-4676: remove the last reference to BlockStorageLocation

        Change-Id: I3853b806da1cce309c5d7d124adb96aa131eaec2
        Reviewed-on: http://gerrit.cloudera.org:8080/5633
        Reviewed-by: Dan Hecht <dhecht@cloudera.com>
        Tested-by: Impala Public Jenkins

        Show
        tarmstrong Tim Armstrong added a comment - IMPALA-4676 : remove the last reference to BlockStorageLocation Change-Id: I3853b806da1cce309c5d7d124adb96aa131eaec2 Reviewed-on: http://gerrit.cloudera.org:8080/5633 Reviewed-by: Dan Hecht <dhecht@cloudera.com> Tested-by: Impala Public Jenkins

          People

          • Assignee:
            tarmstrong Tim Armstrong
            Reporter:
            tarmstrong Tim Armstrong
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development