Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4525

Codegen failure leads to query crash

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: Impala 2.8.0
    • Fix Version/s: Impala 2.8.0
    • Component/s: Backend
    • Labels:

      Description

      If LlvmCodeGen::OptimizeModule() fails, Impala logs a message and continues to execute the query without codegen. However, this typically leads to crashes since ScalarFnCall assumes that codegen succeeds (we hit the DCHECK(scalar_fn_ != NULL)).

      This is more likely now since we reserve memory for optimisation and can fail because of low memory.

      It doesn't appear that we have any testing of this fallback path, so we should probably just get rid of it and fail the query.

        Attachments

          Activity

            People

            • Assignee:
              tarmstrong Tim Armstrong
              Reporter:
              tarmstrong Tim Armstrong
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: