[IMPALA-4421] Rogue variable expansion creates "${RESULTS_DIR" directory inside tests/, which confuses run_tests.py

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.7.0
• Fix Version/s: Impala 2.8.0
• Component/s: Infrastructure
• Labels: test-infra
• Assignee: David Knupp
• Reporter: David Knupp
• Created: 02/Nov/16 18:54
• Updated: 04/Nov/16 19:58
• Resolved: 04/Nov/16 19:55

Description

The error:

~/impala/tests 11> ./run-tests.py --help
Traceback (most recent call last):
  File "./run-tests.py", line 94, in <module>
    test_executor.run_tests(args)
  File "./run-tests.py", line 63, in run_tests
    exit_code = pytest.main(args)
  File "/home/marcel/impala/infra/python/env/local/lib/python2.7/site-packages/_pytest/config.py", line 32, in main
    config = _prepareconfig(args, plugins)
  File "/home/marcel/impala/infra/python/env/local/lib/python2.7/site-packages/_pytest/config.py", line 78, in _prepareconfig
    args = shlex.split(args)
  File "/usr/lib/python2.7/shlex.py", line 279, in split
    return list(lex)
  File "/usr/lib/python2.7/shlex.py", line 269, in next
    token = self.get_token()
  File "/usr/lib/python2.7/shlex.py", line 96, in get_token
    raw = self.read_token()
  File "/usr/lib/python2.7/shlex.py", line 172, in read_token
    raise ValueError, "No closing quotation"
ValueError: No closing quotation

The problem is improperly nested quotes in tests/run-custom-cluster-tests.sh:

ARGS+=('--junitxml="${RESULTS_DIR}/TEST-impala-custom-cluster.xml"')
ARGS+=('--resultlog="${RESULTS_DIR}/TEST-impala-custom-cluster.xml"')