Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4421

Rogue variable expansion creates "${RESULTS_DIR" directory inside tests/, which confuses run_tests.py

    Details

      Description

      The error:

      ~/impala/tests 11> ./run-tests.py --help
      Traceback (most recent call last):
        File "./run-tests.py", line 94, in <module>
          test_executor.run_tests(args)
        File "./run-tests.py", line 63, in run_tests
          exit_code = pytest.main(args)
        File "/home/marcel/impala/infra/python/env/local/lib/python2.7/site-packages/_pytest/config.py", line 32, in main
          config = _prepareconfig(args, plugins)
        File "/home/marcel/impala/infra/python/env/local/lib/python2.7/site-packages/_pytest/config.py", line 78, in _prepareconfig
          args = shlex.split(args)
        File "/usr/lib/python2.7/shlex.py", line 279, in split
          return list(lex)
        File "/usr/lib/python2.7/shlex.py", line 269, in next
          token = self.get_token()
        File "/usr/lib/python2.7/shlex.py", line 96, in get_token
          raw = self.read_token()
        File "/usr/lib/python2.7/shlex.py", line 172, in read_token
          raise ValueError, "No closing quotation"
      ValueError: No closing quotation
      

      The problem is improperly nested quotes in tests/run-custom-cluster-tests.sh:

      ARGS+=('--junitxml="${RESULTS_DIR}/TEST-impala-custom-cluster.xml"')
      ARGS+=('--resultlog="${RESULTS_DIR}/TEST-impala-custom-cluster.xml"')
      

        Activity

        Hide
        dknupp David Knupp added a comment -

        Reviewed-on: http://gerrit.cloudera.org:8080/4918
        Reviewed-by: Jim Apple <jbapple@cloudera.com>
        Tested-by: Internal Jenkins

        Change has been successfully cherry-picked as 381a0f54be6ea1d16c4d65fc7c2747edd388fe8e by Internal Jenkins

        Show
        dknupp David Knupp added a comment - Reviewed-on: http://gerrit.cloudera.org:8080/4918 Reviewed-by: Jim Apple <jbapple@cloudera.com> Tested-by: Internal Jenkins Change has been successfully cherry-picked as 381a0f54be6ea1d16c4d65fc7c2747edd388fe8e by Internal Jenkins

          People

          • Assignee:
            dknupp David Knupp
            Reporter:
            dknupp David Knupp
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development