[IMPALA-4313] Make sure that all binaries we produce contain a .note.gnu.build-id section

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Impala 2.7.0
• Component/s: Infrastructure
• Labels: breakpad infra ramp-up supportability
• Target Version: Product Backlog
• Assignee: Unassigned
• Reporter: Lars Volker
• Created: 18/Oct/16 17:14
• Updated: 02/Nov/18 19:22

Description

Breakpad uses .note.gnu.build-id to identify binaries and falls back to hashing the first page of the text section.

src/common/linux/file_id.cc#148

bool FileID::ElfFileIdentifierFromMappedFile(const void* base,
                                             wasteful_vector<uint8_t>& identifier) {
  // Look for a build id note first.
  if (FindElfBuildIDNote(base, identifier))
    return true;
  // Fall back on hashing the first page of the text section.
  return HashElfTextSection(base, identifier);
}

The latter can lead to collisions on large binaries like impalad. Therefore we should make sure we have .note.gnu.build-id in all binaries. More information can be found here: https://fedoraproject.org/wiki/Releases/FeatureBuildId