Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4111

Backend death tests should not produce minidumps

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 2.8.0
    • Fix Version/s: Impala 2.8.0
    • Component/s: Backend
    • Labels:

      Description

      The backend unit tests that use ASSERT_DEBUG_DEATH (currently just promise-test, but I am adding some more in another patch) will produce minidumps every time the test runs. We should not do that and have test utilities to disable core dumps and mini dumps.

        Activity

        Hide
        tarmstrong Tim Armstrong added a comment -

        IMPALA-4111: backend death tests should not produce minidumps

        Move the existing core dump disabler into a shared utility header and
        also disable minidumps too. Add a macro to simplify use of the disabler.

        Change-Id: I33037f4f77c8188fc2ec46a77083a0a64f6ea404
        Reviewed-on: http://gerrit.cloudera.org:8080/4353
        Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
        Tested-by: Internal Jenkins

        A be/src/testutil/death-test-util.h
        M be/src/util/minidump.cc
        M be/src/util/minidump.h
        M be/src/util/promise-test.cc
        4 files changed, 83 insertions, 24 deletions

        Approvals:
        Internal Jenkins: Verified
        Tim Armstrong: Looks good to me, approved

        Show
        tarmstrong Tim Armstrong added a comment - IMPALA-4111 : backend death tests should not produce minidumps Move the existing core dump disabler into a shared utility header and also disable minidumps too. Add a macro to simplify use of the disabler. Change-Id: I33037f4f77c8188fc2ec46a77083a0a64f6ea404 Reviewed-on: http://gerrit.cloudera.org:8080/4353 Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com> Tested-by: Internal Jenkins — A be/src/testutil/death-test-util.h M be/src/util/minidump.cc M be/src/util/minidump.h M be/src/util/promise-test.cc 4 files changed, 83 insertions , 24 deletions Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved

          People

          • Assignee:
            tarmstrong Tim Armstrong
            Reporter:
            tarmstrong Tim Armstrong
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development