[IMPALA-4104] Fix TestEnv and reenable DCHECK in MemTracker::ConsumeLocal()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.8.0
• Fix Version/s: Impala 2.8.0
• Component/s: Backend
• Target Version: Impala 2.8.0
• Assignee: Tim Armstrong
• Reporter: Tim Armstrong
• Created: 09/Sep/16 04:08
• Updated: 27/Sep/16 21:24
• Resolved: 27/Sep/16 21:24

Description

Adding the bottom DCHECK:

  void ConsumeLocal(int64_t bytes, MemTracker* end_tracker) {
    DCHECK(consumption_metric_ == NULL) << "Should not be called on root.";
    for (int i = 0; i < all_trackers_.size(); ++i) {
      if (all_trackers_[i] == end_tracker) return;
      DCHECK(!all_trackers_[i]->has_limit());
      all_trackers_[i]->consumption_->Add(bytes);
    }
    DCHECK(false) << "end_tracker is not an ancestor";
  }

caused backend test failures, e.g. some BufferedBlockMgr tests because they set up their MemTrackers in a strange way. The DCHECK is useful so this should be fixed.