Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4065

Inline comparator calls into TopN::InsertBatch()

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Impala 2.7.0
    • Fix Version/s: Impala 4.0
    • Component/s: Backend
    • Labels:

      Description

      This is the more interesting follow-on from IMPALA-3815. We should inline the Compare() calls in the codegen'd TopN code to avoid the indirect function pointer call.

      The tricky aspect is that the Compare() calls are called from std::priority_queue, and we don't have a way to force-inline those functions at the moment.

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              sql_forever Qifan Chen
              Reporter:
              tarmstrong Tim Armstrong

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment