[IMPALA-4065] Inline comparator calls into TopN::InsertBatch()

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 2.7.0
• Fix Version/s: Impala 4.0.0
• Component/s: Backend
• Labels: codegen ramp-up
• Target Version: Product Backlog
• Assignee: Qifan Chen
• Reporter: Tim Armstrong
• Created: 02/Sep/16 16:46
• Updated: 03/Nov/20 16:03
• Resolved: 03/Nov/20 16:03

Description

This is the more interesting follow-on from IMPALA-3815. We should inline the Compare() calls in the codegen'd TopN code to avoid the indirect function pointer call.

The tricky aspect is that the Compare() calls are called from std::priority_queue, and we don't have a way to force-inline those functions at the moment.

Issue Links

• is blocked by: IMPALA-3815 Clean up TopN node codegen'd code
• relates to: IMPALA-3816 Codegen perf-critical loops in Sorter