[IMPALA-4061] HdfsAvroScanner::CodegenReadRecord() may generate code with unassigned values

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: Impala 2.7.0
• Component/s: Backend
• Labels: codegen
• Target Version: Product Backlog
• Assignee: Unassigned
• Reporter: Michael Ho
• Created: 01/Sep/16 22:15
• Updated: 14/Aug/17 04:36

Description

    
    Value* ret_val;
    if (field->schema->type == AVRO_RECORD) {
      BasicBlock* insert_before_block =
          (null_block != NULL) ? null_block : end_field_block;
      RETURN_IF_ERROR(CodegenReadRecord(new_path, *field, node, codegen, builder, fn,
          insert_before_block, bail_out, this_val, pool_val, tuple_val, data_val,
          data_end_val));
    } else {
      RETURN_IF_ERROR(CodegenReadScalar(*field, slot_desc, codegen, builder,
          this_val, pool_val, tuple_val, data_val, data_end_val, &ret_val));
    }
    builder->CreateCondBr(ret_val, end_field_block, bail_out);

ret_val is not assigned in the path CodegenReadRecord(). It appears to only affect nested type with avro only which we don't really support.