[IMPALA-4056] toSql() of DistributeParam doesn't work as expected

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Kudu_Impala, Impala 2.7.0
• Fix Version/s: Impala 2.8.0
• Component/s: Frontend
• Labels: ramp-up
• Environment: CentOS 6.7
• Target Version: Impala 2.8.0
• Assignee: Yuanhao Luo
• Reporter: Yuanhao Luo
• Created: 01/Sep/16 07:15
• Updated: 04/Jan/17 23:58
• Resolved: 03/Sep/16 04:54

Description

Originally toSql() of DistributeParam wouldn't print any split rows for type range. As code below shows:

public String toSql() {
    if (num_buckets_ == NO_BUCKETS) {
      StringBuilder builder = new StringBuilder();
      for (ArrayList<LiteralExpr> splitRow : splitRows_) {
        splitRowToString(splitRow);
      }
      return String.format("RANGE(%s) INTO RANGES(%s)", Joiner.on(", ").join(columns_),
          builder.toString());
    } else {
      return String.format("HASH(%s) INTO %d BUCKETS", Joiner.on(", ").join(columns_),
          num_buckets_);
    }
  }

We didn't append the return string of splitRowToString() to builder, so builder.toString() wouldn't print anything.