Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-3877

Support unpatched LLVM

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • Impala 2.7.0
    • Impala 2.11.0
    • Backend

    Description

      We currently depend on a patched version of LLVM to work around a feature/limitation/bug of LLVM's linker. It seems unlikely that the patch will make it into LLVM, so we should implement a workaround.

      The problem is that function call arguments may have different types to the called functions. We should implement a wrapper for the IRBuilder CreateCall() function that adds bitcasts to arguments as appropriate and use that consistently for codegen.

      I implemented a version of this as part of the larger IMPALA-3066, but we could separate this out.

      Attachments

        Issue Links

        is related to

        Improvement - An improvement or enhancement to an existing feature or task. IMPALA-5860 Upgrade LLVM to 3.9.0 or later

        • Major - Major loss of function.
        • Resolved

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tarmstrong Tim Armstrong
            tarmstrong Tim Armstrong
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment