[IMPALA-3682] Improve error handling around SSL configs

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.6.0
• Fix Version/s: Impala 2.7.0
• Component/s: Distributed Exec
• Target Version: Impala 2.7.0, Impala 2.5.4
• Assignee: Henry Robinson
• Reporter: Henry Robinson
• Created: 06/Jun/16 18:25
• Updated: 16/Sep/16 19:20
• Resolved: 14/Jun/16 17:37

Description

In ThriftClientImpl, if loadTrustedCertificates fails, that means an unrecoverable configuration error. Right now we don't acknowledge that in OpenWithRetry(), and just iterate ten times by default. Instead, we should change OpenWithRetry() to check socket_create_status_ up front, and return a status error message before trying to ever call connect().

That might avoid a crash that we've seen during Open() where the SSL configuration was bad.