[IMPALA-3675] consider turning -Werror on for address sanitizer builds

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 2.6.0
• Component/s: Backend
• Labels: newbie static-analysis
• Target Version: Product Backlog
• Assignee: Tim Armstrong
• Reporter: Silvius Rus
• Created: 04/Jun/16 17:46
• Updated: 09/Jan/21 01:35
• Resolved: 09/Jan/21 01:35

Description

Currently it seems we're only using -Werror with debug builds.

The problem is that a number of GCC warnings get issued by the analysis/transformation at -O2 or higher. So there could be warnings in our release builds that we're simply ignoring.

We should consider turning -Werror on in release builds. Perhaps have another "static-analysis" target that does something like this (and use it in GVMs and recommend before submitting code reviews):

g++ ${CXX_FLAGS_RELEASE} -fsyntax-only -Werror -Wfatal-errors ...