Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-3388

Kudu should not throw table loading exceptions for fixable errors

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: Kudu_Impala
    • Fix Version/s: Impala 2.8.0
    • Component/s: Frontend
    • Labels:

      Description

      By throwing a TableLoadingException, that ensures the user wont be able to fix the problems.

      Ex:

        private void loadColumns(List<FieldSchema> schema, HiveMetaStoreClient client,
            Set<String> keyColumns) throws TableLoadingException {
      
          if (keyColumns.size() == 0 || keyColumns.size() > schema.size()) {
            throw new TableLoadingException(String.format("Kudu tables must have at least one"
                + "key column (had %d), and no more key columns than there are table columns "
                + "(had %d).", keyColumns.size(), schema.size()));
          }
      

      To fix the problem above the user could modify the table properties.

        Activity

        Hide
        alex.behm Alexander Behm added a comment -

        casey, would you agree that this is a duplicate of IMPALA-594 or are you referring to Kudu tables specifically?

        Show
        alex.behm Alexander Behm added a comment - casey , would you agree that this is a duplicate of IMPALA-594 or are you referring to Kudu tables specifically?
        Hide
        caseyc casey added a comment -

        Ah yes that is what I was thinking. I'm hoping to fix this for Kudu 1.0 but for Kudu tables only. Are you ok with me keeping this issue to track that?

        Show
        caseyc casey added a comment - Ah yes that is what I was thinking. I'm hoping to fix this for Kudu 1.0 but for Kudu tables only. Are you ok with me keeping this issue to track that?
        Hide
        caseyc casey added a comment -

        If you have some ideas on how to fix this generically I'd be interested to hear them.

        Show
        caseyc casey added a comment - If you have some ideas on how to fix this generically I'd be interested to hear them.
        Hide
        alex.behm Alexander Behm added a comment -

        Sure, we can keep this JIRA. Just making sure we are not duplicating. I'll need to think some more about a generic fix.

        Show
        alex.behm Alexander Behm added a comment - Sure, we can keep this JIRA. Just making sure we are not duplicating. I'll need to think some more about a generic fix.
        Hide
        mjacobs Matthew Jacobs added a comment -

        Dimitris Tsirogiannis, are you aware of any specific cases where we can still get into this situation? I'm assuming it's probably possible but I don't know if it's easy or how to repro. If we can't find anything, let's close it for now. If we can only find obscure cases, let's downgrade this.

        Show
        mjacobs Matthew Jacobs added a comment - Dimitris Tsirogiannis , are you aware of any specific cases where we can still get into this situation? I'm assuming it's probably possible but I don't know if it's easy or how to repro. If we can't find anything, let's close it for now. If we can only find obscure cases, let's downgrade this.
        Hide
        mjacobs Matthew Jacobs added a comment -

        Dimitris Tsirogiannis can we close this as part of the CREATE TABLE work or will this still track any real issues? If the former, let's close this or move it as a child JIRA.

        Show
        mjacobs Matthew Jacobs added a comment - Dimitris Tsirogiannis can we close this as part of the CREATE TABLE work or will this still track any real issues? If the former, let's close this or move it as a child JIRA.
        Hide
        dtsirogiannis Dimitris Tsirogiannis added a comment -

        Closing this as part of the fix for IMPALA-3719. We should reopen if we encounter this again.

        Change-Id: I7b9d51b2720ab57649abdb7d5c710ea04ff50dc1
        Reviewed-on: http://gerrit.cloudera.org:8080/4414
        Reviewed-by: Alex Behm <alex.behm@cloudera.com>
        Tested-by: Internal Jenkins

        Show
        dtsirogiannis Dimitris Tsirogiannis added a comment - Closing this as part of the fix for IMPALA-3719 . We should reopen if we encounter this again. Change-Id: I7b9d51b2720ab57649abdb7d5c710ea04ff50dc1 Reviewed-on: http://gerrit.cloudera.org:8080/4414 Reviewed-by: Alex Behm <alex.behm@cloudera.com> Tested-by: Internal Jenkins

          People

          • Assignee:
            dtsirogiannis Dimitris Tsirogiannis
            Reporter:
            caseyc casey
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development