Details
-
Bug
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
Impala 2.6.0
Description
This code can be optimized for codegen:
for (const FilterContext& ctx: filters_) { if (ctx.local_bloom_filter == NULL) continue; void* e = ctx.expr->GetValue(build_row); uint32_t filter_hash = RawValue::GetHashValue(e, ctx.expr->root()->type(), RuntimeFilterBank::DefaultHashSeed()); ctx.local_bloom_filter->Insert(filter_hash); }
Note also that we know ahead of time whether ctx.local_bloom_filter will be NULL, so we could prepare a list of non-null filters and only iterate over that.
Attachments
Issue Links
- blocks
-
IMPALA-3838 Codegen HdfsParquetScanner::EvalRuntimeFilters()
- Resolved
- is related to
-
IMPALA-3837 Filtering at scan node using bloom filters is 2x slower than filtering at join
- Closed