[IMPALA-2915] Catalog leaks HiveMetaStoreClient connections

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Impala 2.2.4, impala 2.3
• Component/s: Catalog
• Labels: catalog-server resource-management
• Target Version: Impala 2.5.0, Impala 2.3.4
• Assignee: Dimitris Tsirogiannis
• Reporter: Dimitris Tsirogiannis
• Created: 01/Feb/16 18:15
• Updated: 03/Mar/16 06:44
• Resolved: 02/Feb/16 23:44

Description

The catalog is leaking connections to the Hive Metastore. For example, see the reloadTable() function in CatalogServiceCatalog:

   catalogLock_.writeLock().lock();
    synchronized(tbl) {
      long newCatalogVersion = incrementAndGetCatalogVersion();
      catalogLock_.writeLock().unlock();
      MetaStoreClient msClient = getMetaStoreClient();
      org.apache.hadoop.hive.metastore.api.Table msTbl = null;
      try {
        msTbl = msClient.getHiveClient().getTable(db.getName(), tblName.getTable_name());
      } catch (Exception e) {
        throw new TableLoadingException("Error loading metadata for table: " +
            db.getName() + "." + tblName.getTable_name(), e);
      }
      tbl.load(true, msClient.getHiveClient(), msTbl);
      tbl.setCatalogVersion(newCatalogVersion);
      return tbl;
    }