Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-2758

Remove BufferedTupleStream::GetRows()

    Details

      Description

      The BufferedTupleStream::GetRows() API returns all of the rows from a pinned stream in a single row batch. This is not a very good API, particularly if we wish to simplify memory management because it can result in creating an arbitrarily large RowBatch. This comes with unbounded memory overhead for tuple pointers, and has potential to cause problems in code that does not anticipate very large batches.

      Instead we should convert callsites to call BufferedTupleStream::GetNext() and process a batch at a time.

        Attachments

          Activity

            People

            • Assignee:
              tianyiwang Tianyi Wang
              Reporter:
              tarmstrong Tim Armstrong
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: