[IMPALA-2757] Make RowBatch::AtCapacity checks simpler and more efficient

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.3.0
• Fix Version/s: Impala 2.5.0
• Component/s: Backend
• Labels: resource-management
• Target Version: Impala 2.5.0
• Assignee: Tim Armstrong
• Reporter: Tim Armstrong
• Created: 09/Dec/15 00:27
• Updated: 27/Jan/16 15:02
• Resolved: 27/Jan/16 15:02

Description

RowBatch::AtCapacity() is executed per row and currently checks 5+ different conditions. The conditions it checks also arguably do not make sense. E.g. it doesn't check RowBatch::tuple_data_pool_ by default, and it doesn't sum memory consumption from different sources.

We should reduce the number of checks and try to make sure it is checking the correct things.

Issue Links

• is a child of: IMPALA-2755 Clean up memory management in backend