[IMPALA-2689] Log every time codegen is disabled due to NYI

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 2.3.0
• Fix Version/s: Impala 2.10.0
• Component/s: Backend
• Labels: codegen ramp-up supportability
• Target Version: Product Backlog
• Assignee: Anuj Phadke
• Reporter: Skye Wanderman-Milne
• Created: 19/Nov/15 21:22
• Updated: 30/Aug/18 18:09
• Resolved: 18/Aug/17 00:17

Description

Sometimes a function cannot be codegen'd, even with codegen enabled, because some functionality is not implemented (e.g. we cannot codegen the Avro scanner if the file schema does not match the table schema, certain types are not implemented for aggregates). We should always print a message to the log explaining why this is the case, otherwise it's very difficult to figure out why codegen couldn't be used for a certain query. We already log in some cases but not all.

In addition, we could also put these reasons in the runtime profile. Currently we only log if codegen is enabled on an operator, but it would be also be useful to see if it was disabled and why.

Issue Links

• is related to: IMPALA-3151 Impala crash for avro table when casting to char data type
• is related to: IMPALA-2688 Group by on Decimal data type doesn't get CodeGened
• is related to: IMPALA-3212 Enable force code generation