Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-2435

Sorter::AddBatch does not check the Status of unsorted_run_->Init()

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Impala 1.4.1, Impala 2.0.1, Impala 2.1.2, Impala 2.2.4, Impala 2.3.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      While I was reviewing Dimitris's IMPALA-2369 patch, I realized that in AddBatch() we call Run::Init() without checking the return status of it. That means that Dimitris's patch probably won't do much good

      At https://github.com/cloudera/Impala/blob/cdh5-trunk/be/src/runtime/sorter.cc#L1001

          if (cur_batch_index < batch->num_rows()) {
            // The current run is full. Sort it and begin the next one.
            RETURN_IF_ERROR(SortRun());
            RETURN_IF_ERROR(sorted_runs_.back()->UnpinAllBlocks());
            unsorted_run_ = obj_pool_.Add(
                new Run(this, output_row_desc_->tuple_descriptors()[0], true));
            unsorted_run_->Init(); <== RETURN_IF_ERROR
          }
      

      Instead of creating a different patch, I will let Dimitris add it to his IMPALA-2369 patch.

        Attachments

          Activity

            People

            • Assignee:
              dtsirogiannis Dimitris Tsirogiannis
              Reporter:
              ippokratis Ippokratis Pandis
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: