[IMPALA-2344] Remove workaround for sorter.cc:654: Check failed: pinned

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.3.0
• Fix Version/s: Impala 2.7.0
• Component/s: Backend
• Labels: resource-management
• Environment: impalad version 2.3.0-cdh5-INTERNAL DEBUG (build acd68caf7dd931fbc3edf8965298b57297a82aa0); Built on Thu, 10 Sep 2015 22:51:08 PST
• Target Version: Product Backlog
• Assignee: Tim Armstrong
• Reporter: casey
• Created: 15/Sep/15 01:05
• Updated: 13/Sep/16 00:43
• Resolved: 06/Jun/16 00:13

Description

The query below crashed when running with a 430M mem limit on the stress test cluster. It was the only query running at the time. The crash reproduced after a couple of tries.

USE randomness;
SET MEM_LIMIT=430M;
SELECT
t1.tinyint_col_10,
COALESCE(t2.tinyint_col_35, t2.smallint_col_4) AS int_col,
LEAD(187) OVER (PARTITION BY COALESCE(t2.tinyint_col_35, t2.smallint_col_4) ORDER BY COALESCE(t2.tinyint_col_35, t2.smallint_col_4) ASC, t1.tinyint_col_10 DESC) AS int_col_1,
t1.timestamp_col_18 + INTERVAL t2.tinyint_col_35 DAY AS timestamp_col
FROM table_14 t1
LEFT JOIN table_22 t2 ON ((t2.decimal2723_col_34) = (t1.decimal2514_col_16)) AND ((t2.timestamp_col_43) = (t1.timestamp_col_18))
UNION
SELECT
(FLOOR(decimal3707_col_19)) - (COALESCE(SUM(bigint_col_15), 631, -378)) AS decimal_col,
GREATEST(COALESCE(decimal3633_col_2, 122.45), COALESCE(int_col_18, -137)) AS decimal_col_1,
FLOOR(decimal3707_col_19) AS decimal_col_2,
MAX(CAST('1998-01-13 00:00:00' AS TIMESTAMP)) OVER (PARTITION BY (FLOOR(decimal3707_col_19)) - (COALESCE(SUM(bigint_col_15), 631, -378))) AS timestamp_col
FROM table_44
GROUP BY
GREATEST(COALESCE(decimal3633_col_2, 122.45), COALESCE(int_col_18, -137)),
FLOOR(decimal3707_col_19);

Fatal log

F0914 17:44:40.859225  7971 sorter.cc:654] Check failed: pinned

Back trace

#6  0x0000000002047f6d in google::LogMessageFatal::~LogMessageFatal (this=0x7fb821a54180, __in_chrg=<value optimized out>) at src/logging.cc:1836
#7  0x00000000016f0bbe in impala::Sorter::Run::GetNext<false> (this=0xbda9800, output_batch=0xd369e00, eos=0x7fb821a5435f) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/runtime/sorter.cc:654
#8  0x00000000016eaa51 in impala::Sorter::Run::GetNextBatch (this=0xbda9800, output_batch=0xc5944e0) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/runtime/sorter.cc:612
#9  0x00000000016f4d37 in boost::_mfi::mf1<impala::Status, impala::Sorter::Run, impala::RowBatch**>::operator() (this=0xc5944c8, p=0xbda9800, a1=0xc5944e0)
    at /opt/toolchain/boost-pic-1.55.0/include/boost/bind/mem_fn_template.hpp:165
#10 0x00000000016f4a4e in boost::_bi::list2<boost::_bi::value<impala::Sorter::Run*>, boost::arg<1> >::operator()<impala::Status, boost::_mfi::mf1<impala::Status, impala::Sorter::Run, impala::RowBatch**>, boost::_bi::list1<impala::RowBatch**&> > (this=0xc5944d8, f=..., a=...) at /opt/toolchain/boost-pic-1.55.0/include/boost/bind/bind.hpp:303
#11 0x00000000016f484e in boost::_bi::bind_t<impala::Status, boost::_mfi::mf1<impala::Status, impala::Sorter::Run, impala::RowBatch**>, boost::_bi::list2<boost::_bi::value<impala::Sorter::Run*>, boost::arg<1> > >::operator()<impala::RowBatch**> (this=0xc5944c8, a1=@0x7fb821a544b0) at /opt/toolchain/boost-pic-1.55.0/include/boost/bind/bind_template.hpp:32
#12 0x00000000016f4628 in boost::detail::function::function_obj_invoker1<boost::_bi::bind_t<impala::Status, boost::_mfi::mf1<impala::Status, impala::Sorter::Run, impala::RowBatch**>, boost::_bi::list2<boost::_bi::value<impala::Sorter::Run*>, boost::arg<1> > >, impala::Status, impala::RowBatch**>::invoke (function_obj_ptr=..., a0=0xc5944e0) at /opt/toolchain/boost-pic-1.55.0/include/boost/function/function_template.hpp:132
#13 0x00000000015677f0 in boost::function1<impala::Status, impala::RowBatch**>::operator() (this=0xc5944c0, a0=0xc5944e0) at /opt/toolchain/boost-pic-1.55.0/include/boost/function/function_template.hpp:767
#14 0x0000000001567491 in impala::SortedRunMerger::BatchedRowSupplier::Next (this=0xc5944c0, transfer_batch=0x0, done=0x7fb821a54667)
    at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/runtime/sorted-run-merger.cc:67
#15 0x00000000015668a8 in impala::SortedRunMerger::GetNext (this=0x1440e9c0, output_batch=0xcf4d770, eos=0xdbf8698) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/runtime/sorted-run-merger.cc:171
#16 0x00000000016ed60d in impala::Sorter::GetNext (this=0xb4df6c0, output_batch=0xcf4d770, eos=0xdbf8698) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/runtime/sorter.cc:1037
#17 0x000000000168c377 in impala::SortNode::GetNext (this=0xb13d200, state=0xa798400, row_batch=0xcf4d770, eos=0xdbf8698) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/exec/sort-node.cc:98
#18 0x00000000016a7801 in impala::AnalyticEvalNode::ProcessChildBatches (this=0xdbf8380, state=0xa798400) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/exec/analytic-eval-node.cc:545
#19 0x00000000016a937e in impala::AnalyticEvalNode::GetNext (this=0xdbf8380, state=0xa798400, row_batch=0xe215e00, eos=0x1492652c)
    at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/exec/analytic-eval-node.cc:722
#20 0x0000000001697b2b in impala::UnionNode::GetNext (this=0x14926380, state=0xa798400, row_batch=0x7fb821a54b60, eos=0x7fb821a54d5f) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/exec/union-node.cc:150
#21 0x0000000001658ef4 in impala::PartitionedAggregationNode::Open (this=0xa6cef00, state=0xa798400) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/exec/partitioned-aggregation-node.cc:241
#22 0x0000000001558dd8 in impala::PlanFragmentExecutor::OpenInternal (this=0xa798f28) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/runtime/plan-fragment-executor.cc:334
#23 0x0000000001558c7e in impala::PlanFragmentExecutor::Open (this=0xa798f28) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/runtime/plan-fragment-executor.cc:320
#24 0x000000000132d828 in impala::FragmentMgr::FragmentExecState::Exec (this=0xa798d00) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/service/fragment-exec-state.cc:50
#25 0x0000000001325e46 in impala::FragmentMgr::FragmentExecThread (this=0x9bb7320, exec_state=0xa798d00) at /usr/src/debug/impala-2.3.0-cdh5.5.0-SNAPSHOT/be/src/service/fragment-mgr.cc:70
#26 0x0000000001329836 in boost::_mfi::mf1<void, impala::FragmentMgr, impala::FragmentMgr::FragmentExecState*>::operator() (this=0x9af44e0, p=0x9bb7320, a1=0xa798d00)
    at /opt/toolchain/boost-pic-1.55.0/include/boost/bind/mem_fn_template.hpp:165

Issue Links

• relates to: IMPALA-2041 Crash on impala::Sorter::Run::GetNext<true>
• relates to: IMPALA-1590 Remove workarounds for DCHECK in sorter.cc:549 (var_len_blocks[0]->Pin() fails to pin), when running parallel test