Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-2119

Clean up destructors and the fragment/query Close() path

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: Impala 2.2
    • Fix Version/s: None
    • Component/s: Backend
    • Labels:

      Description

      We need to make sure that there is a sane query and fragment Close() path on the query and fragments, i.e. we shouldn't be relying on destructors, shared/scoped_ptrs. The worst offenders are the coordinator and fragment management classes, e.g. PlanFragmentExecutor, FragmentExecState, QueryExecState, Coordinator. At the same time, we should make sure that all ExecNodes, sinks, and other backend classes used for query execution have all cleanup logic in Close() methods. In some cases, Close() methods will need to be added.

        Attachments

          Activity

            People

            • Assignee:
              marcelk Marcel Kornacker
              Reporter:
              mjacobs Matthew Jacobs
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: