[IMPALA-11766] In HdfsScanNode.buildBinaryStatsPredicate, an Expr needs to be cloned

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 4.3.0
• Component/s: Frontend
• Epic Color: ghx-label-4
• Assignee: Steve Carlin
• Reporter: Steve Carlin
• Created: 01/Dec/22 00:07
• Updated: 28/May/23 11:44
• Resolved: 28/May/23 11:44

Description

In HdfsScanNode.buildBinaryStatsPredicate exists the following code:

  private void buildBinaryStatsPredicate(Analyzer analyzer, SlotRef inputSlot,
      BinaryPredicate inputPred, BinaryPredicate.Operator op) {
    // Obtain the rhs expr of the input predicate
    Expr constExpr = inputPred.getChild(1);
    ...
    BinaryPredicate statsPred = new BinaryPredicate(op, slot, constExpr);

This contains a potential bug.  The constExpr is mutable and the creation of the new BinaryPredicate can change the innards of the inputPred Expr.

Issue Links

• is related to: IMPALA-11770 Review Predicate arguments for impact of CNF rewrites