[IMPALA-11716] bin/coverage_helper.sh doesn't work

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 4.2.0
• Fix Version/s: Impala 4.2.0
• Component/s: Infrastructure
• Epic Color: ghx-label-13
• Assignee: Quanlong Huang
• Reporter: Quanlong Huang
• Created: 10/Nov/22 01:47
• Updated: 11/Nov/22 02:45
• Resolved: 11/Nov/22 02:45

Description

Encountered the following error when generating code coverage reports:

$ bin/coverage_helper.sh -report
Generating report in directory: /home/quanlong/workspace/Impala/logs/coverage
Traceback (most recent call last):
  File "/home/quanlong/workspace/Impala/bin/../infra/python/env-gcc10.4.0/bin/gcovr", line 2412, in <module>
    process_datafile(file_, covdata, options)
  File "/home/quanlong/workspace/Impala/bin/../infra/python/env-gcc10.4.0/bin/gcovr", line 845, in process_datafile
    stderr=subprocess.PIPE).communicate()
  File "/home/quanlong/workspace/Impala/toolchain/toolchain-packages-gcc10.4.0/python-2.7.16/lib/python2.7/subprocess.py", line 394, in __init__
    errread, errwrite)
  File "/home/quanlong/workspace/Impala/toolchain/toolchain-packages-gcc10.4.0/python-2.7.16/lib/python2.7/subprocess.py", line 1047, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

logs/coverage/gcovr.out shows the output:

Scanning directory /home/quanlong/workspace/Impala/be for gcda/gcno files...
Found 1277 files (and will process 688)
Processing file: /home/quanlong/workspace/Impala/be/src/gutil/CMakeFiles/gutil.dir/stringprintf.cc.gcda
Running gcov: 'gcov /home/quanlong/workspace/Impala/be/src/gutil/CMakeFiles/gutil.dir/stringprintf.cc.gcda --branch-counts --branch-probabilities --preserve-paths --object-directory /home/quanlong/workspace/Impala/be/src/gutil/CMakeFiles/gutil.dir' in '/home/quanlong/workspace/Impala/be'

All files exist except the "gcov" executable. It can be manually resolved by adding "toolchain/toolchain-packages-gcc10.4.0/gcc-10.4.0/bin" to PATH:

export PATH="$PATH:/home/quanlong/workspace/Impala/toolchain/toolchain-packages-gcc10.4.0/gcc-10.4.0/bin"

However, after this, I saw another error:

$ bin/coverage_helper.sh -report
Generating report in directory: /home/quanlong/workspace/Impala/logs/coverage
Traceback (most recent call last):
  File "/home/quanlong/workspace/Impala/bin/../infra/python/env-gcc10.4.0/bin/gcovr", line 2412, in <module>
    process_datafile(file_, covdata, options)
  File "/home/quanlong/workspace/Impala/bin/../infra/python/env-gcc10.4.0/bin/gcovr", line 884, in process_datafile
    process_gcov_data(fname, covdata, abs_filename, options)
  File "/home/quanlong/workspace/Impala/bin/../infra/python/env-gcc10.4.0/bin/gcovr", line 616, in process_gcov_data
    covered[lineno] = int(segments[0].strip())
ValueError: invalid literal for int() with base 10: '141*'

Issue Links

• is caused by: IMPALA-9999 Update Impala to use GCC 9 or higher
• links to: Code Review