Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-11257

Fix CMake warnings for module names and cmake_minimum_required

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • Impala 4.1.0
    • Impala 4.2.0
    • Infrastructure
    • None
    • ghx-label-4

    Description

      CMake produces warnings during the build. One flavor is complaints about the package names for various cmake_modules. The other flavor is complaining about cmake_minimum_required calls with old versions of CMake.

      CMake Warning (dev) at /opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/cmake-3.22.2/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
        The package name passed to `find_package_handle_standard_args` (PROTOBUF)
        does not match the name of the calling package (Protobuf).  This can lead
        to problems in calling code that expects `find_package` result variables
        (e.g., `_FOUND`) to follow a certain pattern.
      ...
      CMake Deprecation Warning at common/thrift/CMakeLists.txt:19 (cmake_minimum_required):
        Compatibility with CMake < 2.8.12 will be removed from a future version of
        CMake.

      These are ugly and spam the logs. We should fix these.

      Attachments

        Activity

          People

            joemcdonnell Joe McDonnell
            joemcdonnell Joe McDonnell
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: