Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-10649

Check only OS major version during toolchain bootstrap

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • Impala 4.0.0
    • None
    • Infrastructure
    • None
    • ghx-label-1

    Description

      Reviewing bin/bootstrap_toolchain.py while fixing IMPALA-10646 revealed that it checks the OS minor version only when running on Ubuntu. On all other supported platforms (Suse, Centos, Red Hat) the code is happy with just the major version.
      https://github.com/apache/impala/blob/master/bin/bootstrap_toolchain.py#L92-L98 reveals that minor versions are irrelevant for Ubuntu: the code happily maps toolchain versions even across major versions of Ubuntu.
      My proposal is to remove the minor version check from bootstrap_toolchain.py.

      Attachments

        Activity

          People

            laszlog Laszlo Gaal
            laszlog Laszlo Gaal
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: