Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-10226

Change buildall.sh -notests to invoke a single Make target

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 4.0.0
    • Impala 4.0.0
    • Infrastructure
    • None

    Description

      Currently, running "buildall.sh -notests" boils down to invoking make with multiple targets:

       

        if [[ $BUILD_TESTS -eq 0 ]]; then
          # Specify all the non-test targets
          MAKE_TARGETS="impalad statestored catalogd fesupport loggingsupport ImpalaUdf \
              udasample udfsample"
          if (( build_independent_targets )); then
            MAKE_TARGETS+=" cscope fe tarballs"
          fi
        fi
        ${MAKE_CMD} -j${IMPALA_BUILD_THREADS:-4} ${IMPALA_MAKE_FLAGS} ${MAKE_TARGETS}

      Based on the build output, it looks like each make target is invoked individually (with the commands underneath going parallel). This is particularly a problem for impalad (which needs to build the backend) and fe. We want these to run simultaneously, and this limitation prevents that.

      We should create a single target that builds all the things needing to be built for -notests. Then, this will be invoking one target and allowing all the pieces go parallel.

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            joemcdonnell Joe McDonnell
            joemcdonnell Joe McDonnell
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment