Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
Impala 4.0.0
-
None
-
ghx-label-7
Description
In bin/bootstrap_toolchain.py's DownloadUnpackTarball download() function, the exception handler code will delete the download directory:
except: # noqa # Clean up any partially-unpacked result. if os.path.isdir(unpack_dir): shutil.rmtree(unpack_dir) if os.path.isdir(download_dir): # <---- wrong shutil.rmtree(download_dir) raise
This is incorrect. It should only delete the download directory if the download directory is a temporary directory. Otherwise, it would be deleting the actual toolchain directory (and forcing a redownload of everything).