[IMPALA-10044] bin/bootstrap_toolchain.py error handling can delete the toolchain directory

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 4.0.0
• Fix Version/s: Impala 4.0.0, Impala 3.4.1
• Component/s: Infrastructure
• Target Version: Impala 4.0.0
• Epic Color: ghx-label-7
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 03/Aug/20 17:50
• Updated: 05/Feb/21 13:17
• Resolved: 07/Aug/20 03:55

Description

In bin/bootstrap_toolchain.py's DownloadUnpackTarball download() function, the exception handler code will delete the download directory:

    except:  # noqa
      # Clean up any partially-unpacked result.
      if os.path.isdir(unpack_dir):
        shutil.rmtree(unpack_dir)
      if os.path.isdir(download_dir): # <---- wrong
        shutil.rmtree(download_dir)
      raise

This is incorrect. It should only delete the download directory if the download directory is a temporary directory. Otherwise, it would be deleting the actual toolchain directory (and forcing a redownload of everything).