[IGNITE-9428] MVCC TX: MvccQueryTrackerImpl.onDone() semantic is broken.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Fix Version/s: 2.8
• Component/s: mvcc, sql
• Labels: transactions
• Assignee: Unassigned
• Reporter: Roman Kondakov
• Created: 30/Aug/18 08:32
• Updated: 11/Mar/19 06:32
• Resolved: 23/Jan/19 12:55

Description

Due to IGNITE-9256 patch, multiple H2ResultSetIterator#onClose invocation becomes possible. This can be considered as a Closable contract violation and should be fixed.

Also this case revealed a bug in MvccQueryTrackerImpl when multiple onDone() call leads to multiple query finished acks sent back to the MvccCoordinator which leads to the problems with the query tracking and assertion errors.

Reproducer: CacheMvccSqlTxQueriesAbstractTest#testAccountsTxDmlSumSql_WithRemoves_SingleNode 

 

Upd: test was fixed in IGNITE-9373. But MvccQueryTrackerImpl.onDone() issue is still actual.

Issue Links

• is related to: IGNITE-9256 SQL: make sure that fetched results are cleared from iterator when last element is fetched
• relates to: IGNITE-10752 MVCC: Tests invariants are violated sometimes
• links to: GitHub Pull Request #4672
• links to: GitHub Pull Request #4672