[IGNITE-8957] testFailGetLock() constantly fails. Last entry checkpoint history can be empty

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7
• Fix Version/s: 2.7
• Component/s: persistence
• Labels: MakeTeamcityGreenAgain
• Assignee: Andrew Medvedev
• Reporter: Maxim Muzafarov
• Created: 07/Jul/18 09:28
• Updated: 16/Jul/18 10:58
• Resolved: 13/Jul/18 10:57

Description

IgniteChangeGlobalStateTest#testFailGetLock constantly fails with exception:

java.lang.AssertionError
	at org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory.onCheckpointFinished(CheckpointHistory.java:205)
	at org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager$Checkpointer.markCheckpointEnd(GridCacheDatabaseSharedManager.java:3654)
	at org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager$Checkpointer.doCheckpoint(GridCacheDatabaseSharedManager.java:3178)
	at org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager$Checkpointer.body(GridCacheDatabaseSharedManager.java:2953)
	at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110)
	at java.lang.Thread.run(Thread.java:748)

As Sergey Chugunov mentioned, issue can be solved different ways:

It seems we missed a case when lastEntry may be empty. We may choose here from two options:

• Check if histMap is empty inside onCheckpointFinished. If it is just don't log anything (it was the very first checkpoint).
• Check in caller that there is no history, calculate necessary index in caller and pass it to onCheckpointFinished to prepare correct log message.

Issue Links

• relates to: IGNITE-8737 Improve checkpoint logging information
• links to: GitHub Pull Request #4334