[IGNITE-8661] WALItreater is not stopped if can not deserialize record

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.7
• Assignee: Dmitriy Govorukhin
• Reporter: Dmitriy Govorukhin
• Created: 31/May/18 13:13
• Updated: 28/Jun/18 14:56
• Resolved: 28/Jun/18 14:56

Description

Currently, we have the following code in RecordV1Serializer.readWithCrc:

static WALRecord readWithCrc(.....) throws EOFException, IgniteCheckedException {
  
    try (FileInput.Crc32CheckingFileInput in = in0.startRead(skipCrc)) {
      ..... 
    }
    catch (EOFException | SegmentEofException | WalSegmentTailReachedException e) {
        throw e;
    }
    catch (Exception e) {
        throw new IgniteCheckedException("Failed to read WAL record at position: " + startPos, e);
    }
}

So, any runtime error will be remapped to IgniteCheckedException, which will lead to iterator stop due to the following code:

AbstractWalRecordsIterator.advanceRecord:

   try {
         ......
        }
        catch (IOException | IgniteCheckedException e) {
            if (e instanceof WalSegmentTailReachedException)
                throw (WalSegmentTailReachedException)e;

            if (!(e instanceof SegmentEofException))
                handleRecordException(e, actualFilePtr);

            return null;
        }

Any IgniteCheckedException will be ignored and iterator goes ahead to the next segment.

I suggest to make the following changes:
1) It is unexpected behavior, need to fix it. We should only stop iteration on known exceptions
2) Also, need to provide ability skip records by type or some pointer for the StandaloneWalRecordsIterator

Issue Links

• links to: CR-637
• links to: GitHub Pull Request #4155
• links to: TC