[IGNITE-8464] WALIterator broken (race on the switch to the next segment during iteration and concurrent archiving same segment)

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.5
• Component/s: persistence
• Assignee: Anton Kalashnikov
• Reporter: Dmitriy Govorukhin
• Created: 10/May/18 11:20
• Updated: 18/May/18 08:29
• Resolved: 18/May/18 08:29

Description

FileArchiver

final SegmentArchiveResult res = archiveSegment(toArchive);

synchronized (this) {
 while (locked.containsKey(toArchive) && !stopped)
 wait();
}

// Firstly, format working file
if (!stopped)
 formatFile(res.getOrigWorkFile());

synchronized (this) {
 // Then increase counter to allow rollover on clean working file
 changeLastArchivedIndexAndNotifyWaiters(toArchive);

 notifyAll();
}

Some thread may try read segments when archive formating file in work dir (formatFile not synchronized), last archived index is still not updated.

Issue Links

• links to: GitHub Pull Request #3982