[IGNITE-7660] Refactor LSQR algorithm

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Invalid
• Component/s: ml
• Assignee: Unassigned
• Reporter: Anton Dmitriev
• Created: 09/Feb/18 11:10
• Updated: 05/Aug/21 11:46
• Resolved: 23/Jan/20 13:03

Description

This issues is the nest step of the IGNITE-7438 task.

In the IGNITE-7438 the AbstractLSQR implementation has been copied from the SciPy implementation which has been copies from another old implementation. As result the code in the AbstractLSQR looks a bit weird. All variables have meaningless names and the whole algorithm written as the one method.

The goal of this task is to refactor the LSQR code and:

• Make variable names more meaningful.
• Add comments to the variables and result (see LSQRResult).
• Move parts of the algorithm into separate methods where it's appropriate.

Issue Links

• links to: GitHub Pull Request #3548
• links to: GitHub Pull Request #3548