[IGNITE-6542] SocketChannel may not be closed in createTcpClient()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2
• Fix Version/s: 2.4
• Assignee: Ilya Kasnacheev
• Reporter: Ilya Kasnacheev
• Created: 02/Oct/17 14:28
• Updated: 22/Feb/18 16:36
• Resolved: 16/Oct/17 13:43

Description

There's no finally() on ch in TcpCommunicationSpi.createTcpClient()

So there's a long block of code where resource consistency is hanging on a hair. This can lead to file descriptor starvation as well.

Issue Links

• is related to: IGNITE-6071 Client may detect necessity for reconnect for too long
• relates to: IGNITE-6818 In case of incoming communication connection ping the old one if it's alive
• links to: GitHub Pull Request #2787