[IGNITE-6531] Need to add a 'required' field to the SpringResource annotation.

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.3
• Component/s: spring
• Labels: easyfix newbie
• Assignee: joungdal.nam
• Reporter: joungdal.nam
• Created: 29/Sep/17 07:29
• Updated: 02/Jul/18 12:39

Description

In my test environment, only the client is used(setForceServerMode(true)). Operating environments use clients and servers.
Sometimes Injection is not required in the test environment.
NoSuchBeanDefinitionException is not generated by specifying a value of false.

public @interface SpringResource {

/**

• Declares whether the annotated dependency is required.
• <p>Defaults to {@code true}

  .
  */
  boolean required() default true;
  ..

if (!StringUtils.isEmpty(beanName)) {
try

{ bean = springCtx.getBean(beanName); }

catch(NoSuchBeanDefinitionException ne) {
if(annotation.required())

{ throw ne; }
}
}
else {
try { bean = springCtx.getBean(beanCls); } catch(NoSuchBeanDefinitionException ne) {
if(annotation.required()) { throw ne; }

}
}

Issue Links

• links to: GitHub Pull Request#2791
• links to: teamcity