[IGNITE-5839] Unclear exception from BinaryObjectBuilder::build call when builder is reused

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.3
• Assignee: Andrey Mashenkov
• Reporter: Sergey Chugunov
• Created: 26/Jul/17 08:52
• Updated: 17/Oct/17 10:23
• Resolved: 18/Sep/17 17:55

Description

Simple test where BinaryObjectBuilder builder object is reused fails with exception

org.apache.ignite.binary.BinaryObjectException: Wrong value has been set [typeName=SimpleCls, fieldName=str, fieldType=String, assignedValueType=Object]

        IgniteCache<Object, Object> cache = /* obtain a reference to withKeepBinary cache instance */;

        BinaryObjectBuilder bldr = grid(0).binary().builder("SimpleCls");

        bldr.setField("str", "abc");
        c.put(0, bldr.build());

        bldr.setField("str", null);
        c.put(1, bldr.build());

        bldr.setField("str", "def");
        c.put(2, bldr.build()); //exception will be thrown by call bldr.build()

It can be fixed by simply recreating BinaryObjectBuilder instead of reusing the same instance.

However reusing builder object must be either explicitly prohibited or exception must be fixed.

Right now documentation on builder class says nothing about reusing this object.

Issue Links

• links to: GitHub Pull Request #2532
• links to: Upsource review