Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-4770

Script inside javadoc bottom cause compilation error at 1.8.0_121-b13

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.9
    • build
    • None

    Description

      Problem:
      parent/pom.xml:455 contains following:

      <script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document, 'script', 'twitter-wjs');</script>
      

      this script generates "Follow us" at the bottom of the incubator-ignite/target/javadoc/core/index.html.

      this cause compilation error during

      mvn clean package -DskipTests
      

      error

      [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.1:jar (module-javadoc) on project ignite-tools: MavenReportException: Error while creating archive:
      [ERROR] Exit code: 1 - javadoc: error - Argument for -bottom contains JavaScript.
      [ERROR] Use --allow-script-in-comments to allow use of JavaScript.
      

      addition of "--allow-script-in-comments"
      cause compilation issues on any JDK8 before 1.8.0_121-b13

      [ERROR] Failed to execute goal org.apache.maven.plugins:
      maven-javadoc-plugin:2.10.1:jar (module-javadoc) on project ignite-tools:
      MavenReportException: Error while creating archive:
      [ERROR] Exit code: 1 - javadoc: error - invalid flag:
      --allow-script-in-comments
      

      Solution:
      Need to keep button at the bottom of the page, but fix compilation errors.

      Attachments

        Issue Links

          Activity

            People

              daradurvs Vyacheslav Daradur
              avinogradov Anton Vinogradov (Obsolete, actual is "av")
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: